Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

feat(compiler/runtime-vapor): implement v-slots + v-for / v-if #207

Merged
merged 21 commits into from
May 21, 2024
Merged

feat(compiler/runtime-vapor): implement v-slots + v-for / v-if #207

merged 21 commits into from
May 21, 2024

Conversation

Doctor-wu
Copy link
Member

@Doctor-wu Doctor-wu commented May 11, 2024 •
edited
Loading

related #154
relies on #203

implement slots + vFor

  • runtime
  • compiler
  • test case

implement slots + v-if / v-else[-if]

  • compiler
  • test case

DEMO

@netlify Netlify
Copy link

netlify bot commented May 11, 2024 •
edited
Loading

✅ Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 47008f7
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/664a0f2e1238f600089b8c90
😎 Deploy Preview https://deploy-preview-207--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented May 11, 2024 •
edited
Loading

✅ Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 47008f7
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/664a0f2e2707d1000848b827
😎 Deploy Preview https://deploy-preview-207--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 11, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 57 kB (+1.34 kB) 19.4 kB (+411 B) 17.5 kB (+357 B)
runtime-dom.global.prod.js 94.9 kB 35.8 kB 32.2 kB
runtime-vapor.global.prod.js 45.5 kB (+135 B) 17 kB (+33 B) 15.6 kB (+41 B)
vue-vapor.global.prod.js 99.6 kB (+1.4 kB) 34.9 kB (+416 B) 31.4 kB (+325 B)
vue.global.prod.js 152 kB 55.1 kB 49.2 kB

Usages

Name Size Gzip Brotli
createApp 55.3 kB 21.2 kB 19.4 kB
createSSRApp 58.6 kB 22.5 kB 20.5 kB
defineCustomElement 57.6 kB 21.9 kB 20 kB
vapor 45.9 kB (+133 B) 17.1 kB (+40 B) 15.6 kB (+34 B)
overall 69.1 kB 26.2 kB 23.8 kB

@Doctor-wu Doctor-wu mentioned this pull request May 11, 2024
Closed
7 tasks
@Doctor-wu Doctor-wu changed the title feat: implement slots + vFor feat(compiler-vapor, runtime-vapor): implement v-slots + v-for May 11, 2024
@Doctor-wu Doctor-wu changed the title feat(compiler-vapor, runtime-vapor): implement v-slots + v-for feat(compiler-vapor, runtime-vapor): implement v-slots + v-for / v-if / v-else[-if] May 12, 2024
@Doctor-wu Doctor-wu requested review from LittleSound and sxzz May 12, 2024 14:13
sxzz
sxzz suggested changes May 19, 2024
View reviewed changes
@Doctor-wu Doctor-wu requested a review from sxzz May 19, 2024 14:30
@sxzz sxzz merged commit 4e13a57 into main May 21, 2024
@sxzz sxzz changed the title feat(compiler-vapor, runtime-vapor): implement v-slots + v-for / v-if / v-else[-if] feat(compiler/runtime-vapor): implement v-slots + v-for / v-if May 21, 2024
@sxzz sxzz deleted the feature-dynamic-for-slot branch May 21, 2024 00:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LittleSound LittleSound Awaiting requested review from LittleSound

1 more reviewer

@sxzz sxzz sxzz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Doctor-wu @sxzz @LittleSound